Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Ability to Specify Egui Texture Filters #1636

Merged
merged 1 commit into from
May 22, 2022

Conversation

zicklag
Copy link
Contributor

@zicklag zicklag commented May 17, 2022

Very quick draft, but it works for the egui_glow backend.

Not sure that it's a good API or not, and it needs more thought, but pushing this up because I needed it in my project, and other people might want to look at it.

@zicklag zicklag force-pushed the texture-filter-option branch from 4e29667 to 6588a12 Compare May 19, 2022 18:21
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good overall!

I am keen to also add mipmapping as a filtering option, but let's save that for a later PR to keep down the complexity.

Copy link
Contributor Author

@zicklag zicklag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

I addressed most of your points and pushed an update, with just a couple of questions.

Edit: I've still got some build problems to fix, I'll get to that as soon as I can.

@zicklag zicklag force-pushed the texture-filter-option branch from 3f8b180 to b4df5e7 Compare May 21, 2022 16:04
@zicklag zicklag marked this pull request as ready for review May 21, 2022 16:04
@zicklag zicklag force-pushed the texture-filter-option branch from b4df5e7 to 8611de0 Compare May 21, 2022 16:26
Only works for supporting backends:

- egui_glow
@zicklag zicklag force-pushed the texture-filter-option branch from 8611de0 to 410a4d7 Compare May 21, 2022 16:41
@zicklag
Copy link
Contributor Author

zicklag commented May 21, 2022

Make another push, hopefully that fixes CI, sorry for the re-runs.

@emilk emilk merged commit 1a9a0d7 into emilk:master May 22, 2022
@emilk
Copy link
Owner

emilk commented May 22, 2022

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants