Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official WGPU integration #1561

Closed
wants to merge 2 commits into from
Closed

Official WGPU integration #1561

wants to merge 2 commits into from

Conversation

s-nie
Copy link
Contributor

@s-nie s-nie commented May 3, 2022

Based on the discussion in #1555, it looks like providing an official wgpu backend might have its benefits.

This builds on Nils Hasenbanck's egui_wgpu_backend but removes the need for egui_winit_platform and some boilerplate code and instead uses egui's own egui-winit and eframe. This approach worked well in egui 0.17 using the separate epi crate. 0.18 made this approach invalid as epi was moved into eframe.

@hasenbanck Since this is a heavily modified fork from your repository from around egui 0.16, you are still listed as the primary author. I also left the original license files in here, at least for now. Let me know if this is okay for you.

This does not compile right now. But as outlined in #1555, there is some potential for sharing code between the glow and wgpu backend which we can experiment with in this PR.

@hasenbanck
Copy link
Contributor

@s-nie From a license and copyright standpoint this likes fine.

@emilk emilk mentioned this pull request May 3, 2022
@emilk
Copy link
Owner

emilk commented May 3, 2022

Great! I continued work on this in #1564 (because I don't know how to commit to this branch), so I'm closing this now.

@emilk emilk closed this May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants