Add Plot::allow_scroll #1382
Merged
Add Plot::allow_scroll #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
plot_allow_scroll
branch
from
e1d04ae
to
4753d65
Compare
|
@emilk I left this PR as a draft as requested by the So I'll mark this as ready to review and maybe the template should be changed to prevent newbie PRs getting stuck like this in the future. |
emilk
approved these changes
Apr 3, 2022
emilk
reviewed
Apr 3, 2022
| @@ -99,6 +101,7 @@ impl super::View for ContextMenus { | |||
| ui.end_row(); | |||
| if ui.checkbox(&mut self.allow_drag, "Drag").changed() | |||
| || ui.checkbox(&mut self.allow_zoom, "Zoom").changed() | |||
| || ui.checkbox(&mut self.allow_scroll, "Scroll").changed() | |||
There was a problem hiding this comment.
This should really be part of the plot demo instead, but that's for another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to disable scrolling as it conflicts with the scroll action of a ScrollArea but it is currently tied to the zoom functionality which I want to keep.