Make non interactable layers not interact

[juancampa]

Areas in the Tooltip layer shouldn't block interactions to layers below them. Currently, layers under a tooltip won't get hovered if there's a tooltip covering it. Causing the flickering seen in #1239

Closes #1239 - Tooltips flicker when they can't fit on the screen

[juancampa]

This currently breaks context menus as they become non-interactable. Do we need a separate layer for those?

Update: fixed

[juancampa]

I'm not sure why the Area used for menus was marked as .interactable(false) but flipping that boolean fixed the problem. It makes sense the menus are interactable anyway, right?

[emilk]

I'm not sure why the Area used for menus was marked as .interactable(false) but flipping that boolean fixed the problem. It makes sense the menus are interactable anyway, right?

I don't know why it was written like that, and it is likely unintentional. However, there is something else wrong, because your PR breaks the File menu in egui_demo_app

[juancampa]

because your PR breaks the File menu in egui_demo_app

Hmm. Yeah, I see that, it's interesting that it works fine on the web version but not the native one. I'm investigating

[juancampa]

@emilk so I finally figured out what's wrong with that menu. It's a stale app.ron file!

The Areas::areas IdMap is probably persisted on your local machine and the State for that particular menu has interactable set to false.

Deleting that file fixes the issue. Do we have any mechanism to either migrate old save states or delete them if they are incompatible?

[emilk]

@juancampa nice debugging! I think the proper fix is to reset interactable in Area::begin in each frame:

        let mut state = state.unwrap_or_else(|| State {
            pos: default_pos.unwrap_or_else(|| automatic_area_position(ctx)),
            size: Vec2::ZERO,
            interactable,
        });
        state.pos = new_pos.unwrap_or(state.pos);
        state.interactable = interactable; // <--- ADDED

[juancampa]

the proper fix is to reset interactable in Area::begin in each frame

I had the same thought last night. Fixed!

[emilk]

Nice fix, thanks!