Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Individual margins #1219

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Individual margins #1219

merged 3 commits into from
Feb 7, 2022

Conversation

lampsitter
Copy link
Contributor

Closes #1218

@lampsitter lampsitter marked this pull request as ready for review February 6, 2022 16:14
emilk
emilk requested changes Feb 7, 2022
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but left some comments!

egui/src/containers/frame.rs Outdated Show resolved Hide resolved
egui/src/containers/frame.rs Outdated Show resolved Hide resolved
egui/src/containers/frame.rs Outdated Show resolved Hide resolved
egui/src/containers/frame.rs Outdated Show resolved Hide resolved
egui/src/containers/frame.rs Outdated Show resolved Hide resolved
@emilk emilk merged commit 2802e03 into emilk:master Feb 7, 2022
@emilk
Copy link
Owner

emilk commented Feb 7, 2022

Thanks!

@lampsitter lampsitter deleted the margins branch February 7, 2022 10:31
@4JX 4JX mentioned this pull request Feb 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Individual frame margins
2 participants
@lampsitter @emilk