Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextEdit requires double touch to focus on Android #4941

Closed
Zoxc opened this issue Aug 9, 2024 · 2 comments
Closed

TextEdit requires double touch to focus on Android #4941

Zoxc opened this issue Aug 9, 2024 · 2 comments
Labels
bug Something is broken web Related to running Egui on the web

Comments

@Zoxc
Copy link
Contributor

Zoxc commented Aug 9, 2024

TextEdit requires double touch now to focus on Android in 0.28.1. Other however elements still correctly work with a single touch however.

This still occurs on 1f6ae49a5f6bf43a869c215dea0d3028be8d742a.
@Zoxc Zoxc added the bug Something is broken label Aug 9, 2024
@Zoxc
Copy link
Contributor Author

Zoxc commented Aug 21, 2024

It looks like this is because TextEdit does not request focus when clicking. Clicking with a mouse counts as a drag which does request focus, but a touch doesn't count as a drag.

@Zoxc Zoxc mentioned this issue Aug 21, 2024
Merged
@rustbasic rustbasic mentioned this issue Aug 21, 2024
Closed
emilk pushed a commit that referenced this issue Aug 26, 2024
@Zoxc
Request focus on a TextEdit when clicked (#4991)
f996b90 
This request focus on a TextEdit when clicked, so that touch events on
Android can now focus it.

This looks like a reasonable fix for
#4941.
@emilk
Copy link
Owner

emilk commented Aug 27, 2024 •
edited
Loading

This should now be fixed

@emilk emilk closed this as completed Aug 27, 2024
@emilk emilk added the web Related to running Egui on the web label Aug 27, 2024
486c pushed a commit to 486c/egui that referenced this issue Oct 9, 2024
@Zoxc @486c
Request focus on a TextEdit when clicked (emilk#4991)
1867293 
This request focus on a TextEdit when clicked, so that touch events on
Android can now focus it.

This looks like a reasonable fix for
emilk#4941.
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@Zoxc @hacknus
Request focus on a TextEdit when clicked (emilk#4991)
a1359c0 
This request focus on a TextEdit when clicked, so that touch events on
Android can now focus it.

This looks like a reasonable fix for
emilk#4941.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is broken web Related to running Egui on the web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zoxc @emilk