Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top/bottom panels' contents are off-center, and vertical separators don't span them #4773

Closed
valadaptive opened this issue Jul 3, 2024 · 0 comments · Fixed by #4779
Closed

Top/bottom panels' contents are off-center, and vertical separators don't span them #4773

valadaptive opened this issue Jul 3, 2024 · 0 comments · Fixed by #4779
Assignees
@emilk
Labels
bug Something is broken style visuals and theming
Milestone
Next Patch Release

Comments

@valadaptive
Copy link
Contributor

Describe the bug

In v0.28.0, the contents of a TopBottomPanel on top are now shifted downwards by 2px, and vertical separators start 2px below where they should, leaving a gap. This can be clearly seen in the egui.rs demo:

image

For a bottom panel, it's somewhat opposite--items are shifted upwards, and while separators don't leave a gap at the bottom, they do extend too far into the top (note the overdraw between the vertical separator and the horizontal line above:

image

I believe this may have been caused by #4351, but don't quote me on that.

To Reproduce
Steps to reproduce the behavior:

  1. Create an egui app
  2. Add a TopBottomPanel
  3. Add a button to it
  4. Add a vertical separator to it
  5. Observe that the elements are off-center

Expected behavior

Vertical separators should span exactly the height of the panel, and elements with a height of interact_size.y should appear centered.
@valadaptive valadaptive added the bug Something is broken label Jul 3, 2024
@valadaptive valadaptive mentioned this issue Jul 3, 2024
Closed
@emilk emilk added the style visuals and theming label Jul 4, 2024
@emilk emilk added this to the Next Patch Release milestone Jul 4, 2024
@emilk emilk self-assigned this Jul 4, 2024
emilk added a commit that referenced this issue Jul 4, 2024
@emilk
Fix default height of top/bottom panels
0717644 
The inner size is now `interactive_size.y`, like in 0.27.

* Closes #4773
* Broke in #4351

Thanks to @valadaptive for reporting and diagnosing the bug
@emilk emilk mentioned this issue Jul 4, 2024
Merged
@emilk emilk closed this as completed in b31d02d Jul 4, 2024
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@emilk @hacknus
Fix default height of top/bottom panels (emilk#4779)
4a9a80a 
The inner size is now `interactive_size.y`, like in 0.27.

* Closes emilk#4773
* Broke in emilk#4351

Thanks to @valadaptive for reporting and diagnosing the bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
bug Something is broken style visuals and theming
Projects
None yet
Milestone
Next Patch Release
Development

Successfully merging a pull request may close this issue.

Fix default height of top/bottom panels emilk/egui
2 participants
@emilk @valadaptive