Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/cargo_deny.sh fails to install cargo-deny because of an MSRV error #4373

Closed
dataphract opened this issue Apr 17, 2024 · 1 comment · Fixed by #4293
Closed

scripts/cargo_deny.sh fails to install cargo-deny because of an MSRV error #4373

dataphract opened this issue Apr 17, 2024 · 1 comment · Fixed by #4293
Labels
bug Something is broken

Comments

@dataphract
Copy link
Contributor

Describe the bug
While running scripts/cargo_deny.sh, if cargo-deny is not already installed, the step that attempts to install it fails because the latest cargo-deny has an MSRV of 1.74, while the rust-toolchain file sets the toolchain to 1.72, and this affects cargo install.

$ cargo install cargo-deny
    Updating crates.io index
  Installing cargo-deny v0.14.21
    Updating crates.io index

error: failed to compile `cargo-deny v0.14.21`, intermediate artifacts can be found at `/tmp/cargo-installv5Hzhx`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

Caused by:
  package `clap_builder v4.5.2` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.72.0
  Try re-running cargo install with `--locked`

To Reproduce
Steps to reproduce the behavior:

  1. Uninstall cargo-deny if it is already installed.
  2. From the repository root, run cargo install cargo-deny.

Expected behavior
cargo-deny should install without error.

Desktop (please complete the following information):

  • OS: Arch Linux
  • Browser: N/A
  • Version: N/A
@dataphract dataphract added the bug Something is broken label Apr 17, 2024
@YgorSouza
Copy link
Contributor

I tried to fix that in #4293 by adding the +stable argument. I'll try to finish that PR and open it up for review.

emilk added a commit that referenced this issue Apr 21, 2024
Replaces only the cargo_deny.sh script for now. Can be expanded over
time to replace the other shell and python scripts, so only Rust is
needed to work with the repository.

Closes <#2887>
Closes <#4373>

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants