Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled button text color appears green by default #3732

Closed
LuminaSapphira opened this issue Dec 24, 2023 · 2 comments · Fixed by #3744
Closed

Disabled button text color appears green by default #3732

LuminaSapphira opened this issue Dec 24, 2023 · 2 comments · Fixed by #3744
Labels
bug Something is broken

Comments

@LuminaSapphira
Copy link

Describe the bug
The text color of disabled widgets is green when the regular color is not.

To Reproduce
Steps to reproduce the behavior:
The issue can be seen in the demo at https://www.egui.rs/#demo. Just uncheck "Interactive" in the widget gallery.

Alternatively,

  1. Create a disabled button with text supplied as &str (or RichText with no color supplied)
  2. It is green.

Expected behavior
The text is a faded out color of the normal text color.

Screenshots
Enabled
image

Disabled
image

Additional context
As of #3727 (tested by rolling back to git rev e36b981), the button text appears green. It seems like it is not replacing the new PLACEHOLDER color with the appropriate color when disabled (it is graying out the PLACEHOLDER rather than the intended default color). Using RichText with a color does not display this issue.

@LuminaSapphira LuminaSapphira added the bug Something is broken label Dec 24, 2023
@YgorSouza
Copy link
Contributor

The text also turns white in the light theme

image

emilk added a commit that referenced this issue Dec 28, 2023
* Introduced recently in #3727
* Closes #3732
@emilk
Copy link
Owner

emilk commented Dec 28, 2023

Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants