Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epi::WebInfo.web_location_hash is never updated #1139

Closed
awaken1ng opened this issue Jan 20, 2022 · 0 comments · Fixed by #1140
Closed

epi::WebInfo.web_location_hash is never updated #1139

awaken1ng opened this issue Jan 20, 2022 · 0 comments · Fixed by #1140
Labels
bug Something is broken

Comments

@awaken1ng
Copy link
Contributor

Describe the bug
Location hash initialized once in egui_web::backend::AppRunner::new, and never updated afterwards.

This causes the demo not being able to switch between tabs if you open it with a link that contains fragment identifier, e.g. https://emilk.github.io/egui/index.html#demo, after clicking on one of the tabs and updating the current selection, it's then overwritten on next frame.

To Reproduce
Steps to reproduce the behavior:

  1. Open https://emilk.github.io/egui/index.html#demo, #demo part is important
  2. Try opening any other tab, e.g. EasyMark editor

Observed behavior
EasyMark editor tab shows up for one frame, and then reverts back to Demos tab

Expected behavior
EasyMark editor tab to open and stay

Desktop:

  • OS: Linux
  • Browser: Firefox 96, Chromium 97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant