Apply suggestions from code review

Co-authored-by: Emil Ernerfeldt <[email protected]>
emilk · May 27, 2022 · 84f968c · 84f968c
1 parent c83c281
commit 84f968c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -14,7 +14,7 @@ members = [
 
     "examples/confirm_exit",
     "examples/custom_3d_glow",
-    # "examples/custom_3d_three-d",
+    "examples/custom_3d_three-d",
     "examples/custom_font",
     "examples/custom_font_style",
     "examples/custom_window_frame",

diff --git a/eframe/src/epi.rs b/eframe/src/epi.rs
@@ -29,6 +29,7 @@ pub struct CreationContext<'s> {
     /// you might want to use later from a [`egui::PaintCallback`].
     #[cfg(feature = "glow")]
     pub gl: Option<std::sync::Arc<glow::Context>>,
+
     /// Can be used to manage GPU resources for custom rendering with WGPU using
     /// [`egui::PaintCallback`]s.
     #[cfg(feature = "wgpu")]

diff --git a/egui-wgpu/Cargo.toml b/egui-wgpu/Cargo.toml
@@ -35,9 +35,9 @@ egui = { version = "0.18.1", path = "../egui", default-features = false, feature
     "bytemuck",
 ] }
 
-type-map = "0.5.0"
 bytemuck = "1.7"
 tracing = "0.1"
+type-map = "0.5.0"
 wgpu = { version = "0.12", features = ["webgl"] }
 
 # Optional:

diff --git a/egui_glow/src/painter.rs b/egui_glow/src/painter.rs
@@ -396,7 +396,7 @@ impl Painter {
                         if let Some(callback) = callback.callback.downcast_ref::<CallbackFn>() {
                             (callback.f)(info, self);
                         } else {
-                            tracing::warn!("Warning: Unsupported render callback");
+                            tracing::warn!("Warning: Unsupported render callback. Expected egui_glow::CallbackFn");
                         }
 
                         check_for_gl_error!(&self.gl, "callback");