Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with runaway sizing of the canvas when rendering more complex things in egui #140

Closed
wants to merge 1 commit into from

Conversation

9SMTM6
Copy link

@9SMTM6 9SMTM6 commented Jun 22, 2024

See emilk/egui#4660

IDK why the default render doesn't trigger this. Or precisely how this fixes it. But it does.

@emilk
Copy link
Owner

emilk commented Jun 23, 2024

The next release of egui will fix this: emilk/egui#4536

@9SMTM6
Copy link
Author

9SMTM6 commented Jun 23, 2024

Nice.

Now I'm not sure if there was an unintended interaction any longer. I do currently depend on the master branch of egui, so perhaps this was an unforseen interaction there ( I looked through the PR and from my understanding its author did not see something like this happening)? I thought I had also tested this behavior with the current stable release, but honestly I can guarantee that.

Anyways, this doesn't seem to cause any problems at this point, it still fixes the blurry text in some situations - from my understanding - and when updating egui this will retain the intended behavior. So we could merge this (after i remove my comment). Alternatively you fix this yourself, once the release is out, but I think doing so now might save others from my confusion.

@emilk
Copy link
Owner

emilk commented Jun 26, 2024

I'll address this when I update to egui 0.28

@emilk emilk closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants