Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA cache auto updater #104

Closed
wants to merge 5 commits into from
Closed

Conversation

JustFrederik
Copy link

Assets will auto added to the service worker & to the dist folder.
Every time it is compiled it will generate a version file that contains the version. The sw.js will clear the cache when the version updates
I removed the toolchain because I got an error that dependencies need at least rustc 1.67.

@emilk
Copy link
Owner

emilk commented Sep 4, 2023

I removed the toolchain because I got an error that dependencies need at least rustc 1.67.

Let's update instead: #106

@JustFrederik
Copy link
Author

JustFrederik commented Sep 4, 2023

I didn’t know that rfd has problems with 1.72. I tried it with the stable toolchain and it worked for me so I just removed it. Il merge the updates once you added the tool chain version.

@emilk i can't resolve the conflict with cargo.toml since I needed to add build dependencies

@emilk
Copy link
Owner

emilk commented Sep 4, 2023

@emilk i can't resolve the conflict with cargo.toml since I needed to add build dependencies

I don't follow. Why can't you resolve conflicts? I sure can't do it - since you opened your PR from your master branch I cannot edit it.

@JustFrederik
Copy link
Author

JustFrederik commented Sep 4, 2023

Was a dumb mistake. My branch had problems with the latest commit. GitHub was still cached or didn't reload properly or whatever. It showed that the pull request wasn't accepted and my repo was not behind. That's why I thought it was a check.

@JustFrederik
Copy link
Author

@emilk i resolved the issue with the version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants