Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/signals updates #124

Merged
merged 3 commits into from
Dec 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/design/app/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { useState } from 'react'
import * as RadioGroupPrimitive from '@radix-ui/react-radio-group'
import { BorderSolidIcon } from '@radix-ui/react-icons'
import { Label } from '@radix-ui/react-label'
import { motion } from 'framer-motion'
import { motion } from 'motion/react'
import {
Select,
SelectGroup,
Expand Down
2 changes: 1 addition & 1 deletion apps/design/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"@radix-ui/react-label": "2.1.1",
"@radix-ui/react-progress": "1.1.1",
"@radix-ui/react-radio-group": "^1.2.2",
"framer-motion": "6.2.3",
"lib": "workspace:*",
"motion": "11.15.0",
"next": "15.1.2",
"react": "19.0.0",
"react-dom": "19.0.0",
Expand Down
2 changes: 1 addition & 1 deletion apps/games/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
"dependencies": {
"@faker-js/faker": "7.4.0",
"@nanostores/react": "0.7.1",
"framer-motion": "6.2.3",
"just-shuffle": "4.1.1",
"lib": "workspace:*",
"lz-string": "1.5.0",
"million": "2.6.4",
"motion": "11.15.0",
"nanostores": "0.9.5",
"next": "15.1.2",
"react": "19.0.0",
Expand Down
2 changes: 1 addition & 1 deletion apps/games/src/app/wordle/Game.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use client'

import { useEffect, useState } from 'react'
import { motion } from 'framer-motion'
import { motion } from 'motion/react'
import { Header } from 'ui'

enum Color {
Expand Down
4 changes: 3 additions & 1 deletion apps/next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
"@emiljohansson/random-string": "1.1.2",
"@faker-js/faker": "7.4.0",
"@nanostores/react": "0.7.1",
"@preact/signals-core": "1.8.0",
"@preact/signals-react": "2.3.0",
"@radix-ui/react-accessible-icon": "1.1.1",
"@radix-ui/react-label": "2.1.1",
"@radix-ui/react-progress": "1.1.1",
Expand All @@ -27,11 +29,11 @@
"@vercel/analytics": "1.1.1",
"@vercel/kv": "1.0.0",
"crypto-js": "4.2.0",
"framer-motion": "6.2.3",
"jsonwebtoken": "9.0.2",
"just-range": "4.1.1",
"lib": "workspace:*",
"lucide-react": "0.323.0",
"motion": "11.15.0",
"nanostores": "0.9.5",
"next": "15.1.2",
"react": "19.0.0",
Expand Down
40 changes: 0 additions & 40 deletions apps/next/src/app/signals/Content.tsx

This file was deleted.

56 changes: 56 additions & 0 deletions apps/next/src/app/signals/GlobalContent.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
'use client'

import { signal, computed, effect } from '@preact/signals-react'

const gLcount = signal(0)
const gLdouble = computed(() => gLcount.value * 2)

effect(() => {
console.log('Count:', gLcount.value)
console.log('Double:', gLdouble.value)
})

export default function GlobalContent() {
console.log('Render')

return (
<>
<p>Count: {gLcount}</p>
<p>Double: {gLdouble}</p>
<div className="flex">
<button
className="btn-secondary"
onClick={() => {
gLcount.value++
}}
>
Increment
</button>
<button
className="btn-secondary"
onClick={() => {
gLcount.value--
}}
>
Decrement
</button>
<button
className="btn-secondary"
onClick={() => {
gLcount.value = 0
}}
>
Reset
</button>
<button
className="btn-secondary"
onClick={() => {
gLcount.value = 5
}}
>
Set 5
</button>
</div>
</>
)
}
59 changes: 59 additions & 0 deletions apps/next/src/app/signals/LocalContent.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
'use client'

// import { signal, computed, effect } from 'lib/hooks/signals'
// import { useSignals } from '@preact/signals-react/runtime'
import { useSignal, useComputed, useSignalEffect } from '@preact/signals-react'
// import { signal, computed, effect } from '@preact/signals-core'

export default function LocalContent() {
const count = useSignal(0)
const double = useComputed(() => count.value * 2)
console.log('Render')

useSignalEffect(() => {
console.log('Count:', count.value)
console.log('Double:', double.value)
})

return (
<>
<h2>Counter</h2>
<p>Count: {count}</p>
<p>Double: {double}</p>
<div className="flex">
<button
className="btn-secondary"
onClick={() => {
count.value++
}}
>
Increment
</button>
<button
className="btn-secondary"
onClick={() => {
count.value--
}}
>
Decrement
</button>
<button
className="btn-secondary"
onClick={() => {
count.value = 0
}}
>
Reset
</button>
<button
className="btn-secondary"
onClick={() => {
count.value = 5
}}
>
Set 5
</button>
</div>
</>
)
}
10 changes: 10 additions & 0 deletions apps/next/src/app/signals/layout.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import type { PropsWithChildren } from 'react'

export const metadata = {
title: 'Signals',
description: 'Preact Signals in Next.js',
}

export default function Layout({ children }: PropsWithChildren<unknown>) {
return children
}
38 changes: 36 additions & 2 deletions apps/next/src/app/signals/page.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,39 @@
import Content from './Content'
import Section from '@/components/Section'
import Content from '@/components/Content'
import GlobalContent from './GlobalContent'
import LocalContent from './LocalContent'

export default function Page() {
return <Content />
return (
<Content>
<Section size="normal">
<h1 className="sr-only">Signals</h1>
<div className="grid gap-8">
<div>
<h2 className="heading2">Local</h2>
<div className="grid gap-3">
<div>
<LocalContent />
</div>
<div>
<LocalContent />
</div>
</div>
</div>

<div>
<h2 className="heading2">Global 1</h2>
<div className="grid gap-3">
<div>
<GlobalContent />
</div>
<div>
<GlobalContent />
</div>
</div>
</div>
</div>
</Section>
</Content>
)
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use client'

import { useEffect, useState } from 'react'
import { motion } from 'framer-motion'
import { motion } from 'motion/react'
import { Factor } from '@/app/two-way-auth/api/types'

function TwoWayAuthGenerate({ initFactor }: { initFactor: Factor }) {
Expand Down
2 changes: 1 addition & 1 deletion apps/next/src/components/ConfirmButton.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useState, useEffect } from 'react'
import { motion } from 'framer-motion'
import { motion } from 'motion/react'

interface Props {
duration?: number
Expand Down
39 changes: 17 additions & 22 deletions packages/lib/hooks/signals.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// temporary solution from https://github.com/JonAbrams/signals-react-safe/tree/main

import {} from 'react'
import { type ReactElement, useEffect, useMemo, useRef, useState } from 'react'
import { useEffect, useMemo, useRef, useState } from 'react'
import {
Signal,
signal,
Expand All @@ -10,7 +9,7 @@ import {
batch,
type ReadonlySignal,
untracked,
} from '@preact/signals-core'
} from '@preact/signals-react'

export {
signal,
Expand Down Expand Up @@ -62,24 +61,20 @@ export function useSignalEffect(cb: () => void | (() => void)): void {
}, [])
}

const ReactElemType = Symbol.for('react.element') // https://github.com/facebook/react/blob/346c7d4c43a0717302d446da9e7423a8e28d8996/packages/shared/ReactSymbols.js#L15
// const ReactElemType = Symbol.for('react.element') // https://github.com/facebook/react/blob/346c7d4c43a0717302d446da9e7423a8e28d8996/packages/shared/ReactSymbols.js#L15

function SignalValue({ data }: { data: Signal }) {
return useSignalValue(data)
}

Object.defineProperties(Signal.prototype, {
$$typeof: { configurable: true, value: ReactElemType },
type: { configurable: true, value: SignalValue },
props: {
configurable: true,
get() {
return { data: this }
},
},
ref: { configurable: true, value: null },
})
// function SignalValue({ data }: { data: Signal }) {
// return useSignalValue(data)
// }

declare module '@preact/signals-core' {
interface Signal extends ReactElement {}
}
// Object.defineProperties(Signal.prototype, {
// $$typeof: { configurable: true, value: ReactElemType },
// type: { configurable: true, value: SignalValue },
// props: {
// configurable: true,
// get() {
// return { data: this }
// },
// },
// ref: { configurable: true, value: null },
// })
4 changes: 2 additions & 2 deletions packages/lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
"test:ci": "npm run test"
},
"dependencies": {
"@preact/signals-core": "1.5.0",
"@preact/signals-react": "1.3.7",
"@preact/signals-core": "1.8.0",
"@preact/signals-react": "2.3.0",
"next": "15.1.2",
"react": "19.0.0",
"react-dom": "19.0.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
"@radix-ui/react-progress": "1.1.1",
"@radix-ui/react-select": "2.1.4",
"@radix-ui/react-slider": "1.2.2",
"framer-motion": "6.2.3",
"lib": "workspace:*",
"motion": "11.15.0",
"next": "15.1.2",
"react": "19.0.0",
"react-dom": "19.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/Progress.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Root, Indicator } from '@radix-ui/react-progress'
import { motion } from 'framer-motion'
import { motion } from 'motion/react'
import { classNames } from 'lib/utils/string'

export const Progress = ({ progress }: { progress: number }) => {
Expand Down
Loading
Loading