properly support nested ERB for .jst.hamlc with Sprockets 4#193
properly support nested ERB for .jst.hamlc with Sprockets 4#193mathieujobin merged 1 commit intoemilioforrer:masterfrom teamsimplepay:erb_support_for_jst_sprockets4
Conversation
|
I don't have a clear understand of what problem it fixes and how many people would benefit from the change. is it possible to add some tests that would demonstrate the problem and be solved by this change? |
|
@mathieujobin we don't use this feature, but logically it's similar to #192 -- you want to associate a file extension with a single MIME type and register the right transformers to get it to the right MIME type which we want as the output. You can see that the same MIME type is being used for |
hi @ashkulz @mathieujobin, I'm sorry for the late response due to my personal issues. The PR LGTM though |
While we don't really use this, there's a logical bug here which will cause an issue if nested ERB templates are used with
.jst.hamlcfiles.@voducvu can you also test this and verify that it works before @mathieujobin approves/merges this?