fix: [#189] Fix .hamlc is unexpectedly processed by JstProcessor#190
fix: [#189] Fix .hamlc is unexpectedly processed by JstProcessor#190voducvu wants to merge 2 commits intoemilioforrer:masterfrom
Conversation
mathieujobin
left a comment
mathieujobin
left a comment
There was a problem hiding this comment.
@phenchaw Can you have a look at this patch please?
mathieujobin
left a comment
mathieujobin
left a comment
There was a problem hiding this comment.
appears to work with Sprockets 3 but not 4 ?!?
please have a look at the tests results
|
@voducvu seems like something is broken with sprockets 4 can you please have a look ? |
|
@mathieujobin Sorry, i'm quite busy now. I'll look into it when I have more time. |
|
Depending on which one gets merged first, this PR or #191 may need to be adjusted since there's a conflict. |
|
@mathieujobin please see 3922a3c -- it's an issue with Rack 3 compatibility and makes the CI green. Should I make it as a separate PR? |
mathieujobin
left a comment
mathieujobin
left a comment
There was a problem hiding this comment.
I assume this was equivalent to #191 but we don't need both right?
I'm surprise to see a merge conflicts between the two.
please open a new PR if what is merged is incomplete.
thanks
|
@mathieujobin it's not equivalent to #191. Please help me merge #192. |
3 participants
Separate mimetype for .hamlc and .jst.hamlc so that the hamlc is only processed by HamlCoffeeAssets::Transformer and jst.haml is processed by ::HamlCoffeeAssets::Transformer and JstProcessor