Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tests for complex options #65

Merged
merged 1 commit into from
Mar 3, 2018

Conversation

@emicklei
Copy link
Owner

emicklei commented Mar 2, 2018

thanks, will look into this one

@emicklei
Copy link
Owner

emicklei commented Mar 3, 2018

starting from this comment in Proto3 spec

// alternative aggregate syntax (uses TextFormat):

I found this in https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.text_format

static bool TextFormat::Parse(
        io::ZeroCopyInputStream * input,
        Message * output)
Parses a text-format protocol message from the given input stream to the given message object.

This function parses the human-readable format written by Print(). Returns true on success. The message is cleared first, even if the function fails – See Merge() to avoid this behavior.

Example input: "user {\n id: 123 extra { gender: MALE language: 'en' }\n}"

No real spec found so I guess we keep doing exception-driven-developement

@emicklei emicklei merged commit 8ac4c5b into emicklei:master Mar 3, 2018
emicklei added a commit that referenced this pull request Mar 3, 2018
* add multiline test for issue #59

* concat multiple aggregate string constants, issue #59

* fix issue 50

* Additional tests for complex options (#65)

* add multiline test for issue #59

* concat multiple aggregate string constants, issue #59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants