New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oneof and service options not supported #43

Closed

bufdev opened this issue Jan 2, 2018 · 1 comment

Contributor

bufdev commented Jan 2, 2018 •

edited

Loading

They are valid:

https://github.com/google/protobuf/blob/master/src/google/protobuf/descriptor.proto#L589
https://github.com/google/protobuf/blob/master/src/google/protobuf/unittest_custom_options.proto#L108

There may be other option types not handled, will check as I go.

Update - service options also not handled https://github.com/google/protobuf/blob/master/src/google/protobuf/descriptor.proto#L632

bufdev changed the title ~~Oneof options not supported~~ Oneof and service options not supported

emicklei pushed a commit that referenced this issue


          allow oneof and service to have option, issue #43

ded2389

emicklei added a commit that referenced this issue


          allow oneof and service to have option, issue #43 (#62)

efd3625

Owner

emicklei commented Mar 4, 2018

closing this as #62 has been merged.

emicklei closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment