Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds failing due to missing goproperties repo #36

Open
GUI opened this issue Jul 16, 2015 · 3 comments
Open

Builds failing due to missing goproperties repo #36

GUI opened this issue Jul 16, 2015 · 3 comments

Comments

@GUI
Copy link
Contributor

GUI commented Jul 16, 2015

I'm trying to build mora in a new environment, but it's failing because it looks like the emicklei/goproperties repository has been deleted from github: https://github.com/emicklei/goproperties Was this intentional? I think I was building successfully last month when I thinks this repo still existed.

$ go get
# cd .; git clone https://github.com/emicklei/goproperties /tmp/gocode/src/github.com/emicklei/goproperties
Cloning into '/tmp/gocode/src/github.com/emicklei/goproperties'...
ERROR: Repository not found.
fatal: Could not read from remote repository.

I found the original upstream repo at dmotylev/goproperties, so I'm not sure if mora could be switched over to use that directly, or if there was relevant changes in your forked repo that are needed.

Thanks!

@emicklei
Copy link
Owner

oops, deleted while thinking i didn't use it anymore. Most other projects are using the properties package of frank schroder. sorry about this mistake.
At the moment i am on a 3wk holiday with limited access. Maybe you are willing to create a PR for this?

@emicklei
Copy link
Owner

ps the pkg i was referring to is magiconair/properties

GUI added a commit to GUI/mora that referenced this issue Jul 18, 2015
This fixes fresh builds since the emicklei/goproperties repo was deleted
(emicklei#36).
@GUI
Copy link
Contributor Author

GUI commented Jul 18, 2015

No worries or rush on your holiday. Thanks for the pointer on the magiconair/properties library. I've submitted a pull request using that library instead, and that seems to be working for my purposes. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants