Skip to content

fix(analyzers): unblock main — S3241 fires on three unused-return extension methods #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emeraldleaf merged 1 commit into from
Jun 2, 2026
Merged

fix(analyzers): unblock main — S3241 fires on three unused-return extension methods #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions NextAurora.ServiceDefaults/Extensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public static TBuilder ConfigureOpenTelemetry<TBuilder>(this TBuilder builder) w
return builder;
}

private static TBuilder AddOpenTelemetryExporters<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
private static void AddOpenTelemetryExporters<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
{
var useOtlpExporter = !string.IsNullOrWhiteSpace(builder.Configuration["OTEL_EXPORTER_OTLP_ENDPOINT"]);

Expand All @@ -119,8 +119,6 @@ private static TBuilder AddOpenTelemetryExporters<TBuilder>(this TBuilder builde
// builder.Services.AddOpenTelemetry()
// .UseAzureMonitor();
//}

return builder;
}

public static TBuilder AddDefaultHealthChecks<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
Expand Down Expand Up @@ -166,7 +164,7 @@ public static WebApplication MapDefaultEndpoints(this WebApplication app)
return app;
}

private static TBuilder AddDefaultAuthentication<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
private static void AddDefaultAuthentication<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
{
var authority = builder.Configuration["Authentication:Authority"]
?? builder.Configuration["Keycloak:Url"];
Expand All @@ -177,7 +175,7 @@ private static TBuilder AddDefaultAuthentication<TBuilder>(this TBuilder builder
// so UseAuthentication/UseAuthorization don't throw, but no tokens are validated.
builder.Services.AddAuthentication();
builder.Services.AddAuthorization();
return builder;
return;
}

builder.Services.AddAuthentication(JwtBearerDefaults.AuthenticationScheme)
Expand Down Expand Up @@ -207,8 +205,6 @@ private static TBuilder AddDefaultAuthentication<TBuilder>(this TBuilder builder
});

builder.Services.AddAuthorization();

return builder;
}

/// <summary>
Expand All @@ -231,7 +227,7 @@ private static TBuilder AddDefaultAuthentication<TBuilder>(this TBuilder builder
/// migrations a behavior-change debugging nightmare.
/// </para>
/// </summary>
private static TBuilder AddNextAuroraApiVersioning<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
private static void AddNextAuroraApiVersioning<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
{
builder.Services
.AddApiVersioning(options =>
Expand All @@ -249,8 +245,6 @@ private static TBuilder AddNextAuroraApiVersioning<TBuilder>(this TBuilder build
// generated docs/URLs (so Swagger UI shows "/api/v1/products" not the template).
options.SubstituteApiVersionInUrl = true;
});

return builder;
}

/// <summary>
Expand Down
Loading