chore(deps): bump Aspire.AppHost.Sdk 13.3.0 → 13.3.5 to unblock Dependabot PR #35#62
Merged
Merged
Conversation
…dabot PR #35 PR #35 (Dependabot bump of the aspire group) bumps the Aspire.Hosting.* runtime packages from 13.3.0 → 13.3.5 in Directory.Packages.props but does not touch Aspire.AppHost.Sdk, which Dependabot can't see (the SDK pin lives in NextAurora.AppHost.csproj as a <Project Sdk="..."> attribute, not a NuGet PackageVersion). Per CLAUDE.md "Package Management → Aspire SDK and runtime packages must match — including minor versions" — a minor mismatch surfaces at AppHost startup as DCP rejecting startup with "Newer version of the Aspire.Hosting.AppHost package is required." Same trap CodeRabbit flagged on #35. This PR bumps the SDK to 13.3.5 so that: - main has SDK 13.3.5 + packages 13.3.0 (SDK ≥ packages → OK) - After @dependabot rebase on #35: SDK 13.3.5 + packages 13.3.5 (exact match → OK) Once this lands on main, comment `@dependabot rebase` on PR #35 to pick up the new SDK floor and merge. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe Aspire.AppHost.Sdk version in ChangesAspire AppHost SDK Version Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks PR #35 (Dependabot bump of the aspire group). CodeRabbit correctly flagged the alignment issue on #35: Directory.Packages.props bumps `Aspire.Hosting.*` to 13.3.5, but `NextAurora.AppHost.csproj` is still on `Aspire.AppHost.Sdk/13.3.0`. Dependabot can't bump the SDK because it's a `<Project Sdk="...">` attribute, not a NuGet PackageVersion — outside its visibility.
This is exactly the CLAUDE.md rule the project encoded:
The encoding loop working as designed — the rule lives in CLAUDE.md, CodeRabbit applies it at PR-review time.
Changes
One line:
```diff
-<Project Sdk="Aspire.AppHost.Sdk/13.3.0">
+<Project Sdk="Aspire.AppHost.Sdk/13.3.5">
```
Intermediate state after merge (before #35 rebases): SDK 13.3.5 + packages 13.3.0. The CLAUDE.md rule allows `SDK ≥ packages`, so AppHost still boots cleanly. Once #35 rebases against this, both align at 13.3.5 (exact match).
Pattern
Same shape as PR #33 (EF Core bump that unblocked PR #32's microsoft-extensions group): a small companion PR against main that lifts a floor Dependabot can't see, so the grouped bump can rebase cleanly.
Follow-up
After this merges:
```
gh pr comment 35 --body "@dependabot rebase"
```
Dependabot rebuilds against the new SDK floor and #35's CI should go green for the alignment dimension. (Other CodeRabbit findings on #35 still need to be addressed — the label-warning is one; check the latest review for the rest.)
🤖 Generated with Claude Code
Summary by CodeRabbit