chore(deps): group FluentValidation / Grpc / Testcontainers so companion packages can't skew#178
Merged
Merged
Conversation
…ion packages bump in lockstep #123 (FluentValidation 12.1.1) and #124 (FluentValidation.DependencyInjectionExtensions) were ungrouped, so they opened as separate PRs — merging #123 alone left main with FluentValidation core at 12.1.1 and its DI-extensions companion a full major behind at 11.11.0 (an unsupported pairing: 11.x extensions built against 11.x APIs, running on 12.x core). Same family-skew class as the WolverineFx.RabbitMQ drift (#176). The CLAUDE.md "families move together" rule can't prevent this — dependabot doesn't read CLAUDE.md. The mechanical fix is a dependabot group, which every other multi-package family here already has (wolverine, entity-framework, microsoft-extensions, aspire, opentelemetry). This adds groups for the three that were still ungrouped and could skew the same way: FluentValidation* (2 pkgs), Grpc.* (2), Testcontainers* (3). Also refreshed the stale WolverineFx ignore comment ("Stay on 5.x" → the 5→6 migration landed in #154; the family is on 6.17.3 and the ignore now defers 7.0+). Policy unchanged. Does NOT fix the current live skew — #124 (rebasing) closes that. This prevents recurrence. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughDependabot now groups additional NuGet package families into weekly updates, and its WolverineFx ignore-rule comment reflects the completed 5→6 migration and deferred 7.0+ major versions. ChangesDependabot configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
emeraldleaf
added a commit
that referenced
this pull request
Jul 20, 2026
… groups (they're transitively coupled) (#185) Microsoft.AspNetCore.* transitively depends on Microsoft.EntityFrameworkCore.Relational, so an AspNetCore bump pulls a newer EF.Relational and downgrades it against the pinned EF Core → NU1605. As two separate groups they came as two PRs that merged out of step and broke the build TWICE: #155 (Aug) and again #180/#181 this week (AspNetCore 10.0.10 needs EF 10.0.10; the EF group PR was separate). #178 grouped the standalone families (FluentValidation/Grpc/Testcontainers) but not this CROSS-family transitive coupling. Merging the two groups into one (`microsoft-aspnet-ef`) means one PR, so AspNetCore and EF Core always move together — the NU1605 skew becomes structurally impossible. Npgsql EF provider rides along (same cadence). Config-only, no code/package change — architecture-review gate exempt. Does not fix the current #180 — merge #181 (EF 10.0.10) first, then #180 rebases green. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recurrence this prevents
FluentValidationandFluentValidation.DependencyInjectionExtensionswere ungrouped independabot.yml, so they came as separate PRs (#123, #124). Merging #123 alone left main skewed — core at 12.1.1, the DI-extensions companion a full major behind at 11.11.0 (11.x extensions built against 11.x APIs, now running on 12.x core). Same family-skew class as theWolverineFx.RabbitMQdrift fixed in #176.The CLAUDE.md "families move together" rule can't prevent this — dependabot doesn't read CLAUDE.md. The mechanical fix is a dependabot group, which every other multi-package family here already has.
Change
Adds groups for the three multi-package families that were still ungrouped and skew-prone:
fluent-validation→FluentValidation*(2 pkgs) — the one that just bit usgrpc→Grpc.*(2 pkgs —Grpc.AspNetCore,Grpc.Tools)testcontainers→Testcontainers*(3 pkgs — MsSql, PostgreSql, core)Also refreshed the stale
WolverineFxignore comment ("Stay on 5.x" → the 5→6 migration landed in #154; family's on 6.17.3, so the ignore now defers 7.0+). Policy unchanged, comment only.Scope
🤖 Generated with Claude Code
Summary by CodeRabbit