-
Notifications
You must be signed in to change notification settings - Fork 58
Drop attrs typing workaround #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Blocker to wait until the next attrs version is out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since this is already blocked by @Scienfitz review
7f5e396 to
b663a13
Compare
deep_mappingb663a13 to
f1fd5f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes attrs typing workarounds that were previously needed due to upstream issues in the attrs library, now that these issues have been fixed in the new attrs version.
- Updates the attrs dependency requirement from >=24.1.0 to >=25.4.0
- Removes workaround lambda functions and imports that were needed for older attrs versions
- Simplifies validator syntax to use the now-supported list format
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Updates attrs dependency to version 25.4.0 to enable removal of workarounds |
| baybe/utils/metadata.py | Removes lambda workaround for value_validator in deep_mapping |
| baybe/parameters/substance.py | Removes and_ import and replaces validator syntax with list format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Now fixed upstream in the new
attrsversion.