Skip to content

Conversation

@AdrianSosic
Copy link
Collaborator

@AdrianSosic AdrianSosic commented Jul 28, 2025

@AdrianSosic AdrianSosic self-assigned this Jul 28, 2025
@AdrianSosic AdrianSosic added the typing Typing related things label Jul 28, 2025
@AdrianSosic
Copy link
Collaborator Author

Blocker to wait until the next attrs version is out

Scienfitz

This comment was marked as duplicate.

Copy link
Collaborator

@AVHopp AVHopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since this is already blocked by @Scienfitz review

@Scienfitz Scienfitz added the on hold PR progress is awaiting for something else to continue label Jul 28, 2025
@AdrianSosic AdrianSosic force-pushed the typing/deep_mapping branch from 7f5e396 to b663a13 Compare July 29, 2025 08:31
@AdrianSosic AdrianSosic changed the title Drop typing workaround for deep_mapping Drop attrs typing workaround Jul 29, 2025
@Scienfitz Scienfitz added on hold PR progress is awaiting for something else to continue and removed on hold PR progress is awaiting for something else to continue labels Sep 1, 2025
@Copilot Copilot AI review requested due to automatic review settings October 7, 2025 09:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes attrs typing workarounds that were previously needed due to upstream issues in the attrs library, now that these issues have been fixed in the new attrs version.

  • Updates the attrs dependency requirement from >=24.1.0 to >=25.4.0
  • Removes workaround lambda functions and imports that were needed for older attrs versions
  • Simplifies validator syntax to use the now-supported list format

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
pyproject.toml Updates attrs dependency to version 25.4.0 to enable removal of workarounds
baybe/utils/metadata.py Removes lambda workaround for value_validator in deep_mapping
baybe/parameters/substance.py Removes and_ import and replaces validator syntax with list format

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AdrianSosic AdrianSosic removed the on hold PR progress is awaiting for something else to continue label Oct 7, 2025
@AdrianSosic AdrianSosic merged commit 38f5121 into main Oct 7, 2025
10 of 12 checks passed
@AdrianSosic AdrianSosic deleted the typing/deep_mapping branch October 7, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typing Typing related things

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants