Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve responsiveness on macos: add support for kFSEventStreamCreateFlagNoDefer #230

Closed
iwelch opened this issue Jul 4, 2019 · 4 comments

Comments

@iwelch
Copy link

iwelch commented Jul 4, 2019

hi enrico---in the docs, you probably want to change "OS X" to "macos" now.

even with a latency request of 0.2, fswatch sometimes takes several seconds. Other apps, liked Marked 2 (https://marked2app.com/) are always instant, using fsevents.

regards, /iaw

@emcrisostomo
Copy link
Owner

Thank you very much @iwelch: in fact fswatch doesn't allow you to specify the kFSEventStreamCreateFlagNoDefer flag (libfswatch does):

Here is the documentation and the rationale for the behaviour of fswatch is:

This is the default behavior and is more appropriate for background, daemon or batch processing apps.

I'm marking this as an enhancement.

@iwelch
Copy link
Author

iwelch commented Dec 30, 2019

Suggestion: If fswatch is running on a tty, make fast check the update. if fswatch is invoked in batch, make slow check the update. (and maybe allow a flag to toggle.)

@emcrisostomo
Copy link
Owner

Thanks, that's a good suggestion indeed.

@emcrisostomo
Copy link
Owner

This has been implemented in master. Thanks @iwelch

@emcrisostomo emcrisostomo changed the title really slow on macos Improve responsiveness on macos: add support for kFSEventStreamCreateFlagNoDefer Jun 14, 2022
emcrisostomo added a commit that referenced this issue Jun 14, 2022
emcrisostomo added a commit that referenced this issue Jun 14, 2022
emcrisostomo added a commit that referenced this issue Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants