-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement manifest.json output #995
base: main
Are you sure you want to change the base?
Implement manifest.json output #995
Conversation
What are you actually trying to do with the asset map? Because I am dubious about the value of asset maps. Historically they have caused lock-in to specific output formats which reduces our ability to optimize builds without breaking the format. |
These css imports are not swapped for their chunked versions: |
So, my main use case is valid -- I need to be able to manually specify the CSS I want inside a shadow dom. |
How much do you care about specifically getting the traditional app.css & vendor.css (which are not module-aware and don't go through webpack at all) vs getting styles that you can control in a more module-aware way? Because if it's just about those two traditional output files, I would rather special-case those and create a way to express a dependency on them from within an app's code. Whereas if you want to send your styles through webpack and avoid the legacy style pipeline, you can establish your own webpack entrypoint for them in order to take control over their output URL. Either way, I don't think the solution is an asset manifest. Rather, it's a way to express a dependency on output URLs from within your code. Related to the things discussed in emberjs/rfcs#763 |
Yeah, I mean having things be more proper and easy with less hacks is def a direction I want to go in. |
Resolves: #993
Todo:
Questions: