Restructure workspaceDir logic #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Sep 28, 2021
Consolidate the logic for workspaceDir (the tmp location used for stage3) so that a proper building into message can be displayed.
thoov
force-pushed
the
building-into-cleanup
branch
from
cd464fe
to
9c35918
Compare
rwjblue
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate the logic for workspaceDir (the tmp location used for stage3) so that a proper
Building into ...message can be displayed (it is currently displayed in the middle of other console.ui writes and can be lost / looks incorrect). This also standardizes the actual outputted "Building into ..." location and our internal workspaceDir.Building into now appears at the top of stdout:
Note: This is a breaking change due to the fact that we no longer support the
onOutputPathhook.