Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom package rules for ember-basic-dropdown #928

Merged

Conversation

mydea
Copy link
Contributor

@mydea mydea commented Aug 20, 2021

Based on #921 (comment), we do not need the custom rules anymore, since ember-basic-dropdown has wrapped everything in ensure-safe-component now anyhow (https://github.com/cibernox/ember-basic-dropdown/blob/master/CHANGELOG.md)

@ef4 ef4 merged commit 7ceb52a into embroider-build:master Aug 20, 2021
@ef4
Copy link
Contributor

ef4 commented Aug 20, 2021

Thanks.

@rwjblue rwjblue added the bug Something isn't working label Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants