upgrade @ember/test-helpers

[stefanpenner]

this also upgrades ember-cli, not because of this pull request but because ember-beta and ember-canary impose a minimum version of ember-cli, as they dropped the Ember global and older versions of ember-cli still reference it...

[fixes #926]

[stefanpenner]

node test failures I will investigate next (likely tomorrow AM)

FAIL packages/compat/tests/stage2.test.js (123.323s)
  ● stage2 build › engines with css › lazy engine css is imported

    assets/_engine_/lazy-engine.js
    Exected: "  if (macroCondition(!getGlobalConfig().fastboot?.isRunning)) {
    i(\"../../node_modules/lazy-engine/lazy-engine.css\");
      }"
    Received: "
    import { importSync as i, macroCondition, getGlobalConfig } from '@embroider/macros';
    let w = window;
    let d = w.define;·
      if (macroCondition(!getGlobalConfig().fastboot?.isRunning)) {
    i(\"../../node_modules/lazy-engine/lazy-engine/__COMPILED_STYLES__/lazy-engine.css\");
      }·
    d(\"lazy-engine/config/_environment_browser_\", function(){ return i(\"../../node_modules/lazy-engine/config/_environment_browser_.js\");});
    d(\"lazy-engine/config/environment\", function(){ return i(\"../../node_modules/lazy-engine/config/environment.js\");});
    d(\"lazy-engine/engine\", function(){ return i(\"../../node_modules/lazy-engine/engine.js\");});
    d(\"lazy-engine/package\", function(){ return i(\"../../node_modules/lazy-engine/package.json\");});······
    "

      718 |
      719 |     test('lazy engine css is imported', function () {
    > 720 |       expectFile('assets/_engine_/lazy-engine.js')
          |       ^
      721 |         .matches(`  if (macroCondition(!getGlobalConfig().fastboot?.isRunning)) {
      722 | i(\"../../node_modules/lazy-engine/lazy-engine.css\");
      723 |   }`);

      at Object.<anonymous> (packages/compat/tests/stage2.test.ts:720:7)

FAIL packages/compat/tests/addon-styles.test.js (22.146s)
  ● addon.styles tests › all addon CSS gets convert to implicit-styles

    node_modules/my-addon3/package.json
    Exected: "./my-addon3.css"
    Received: ["./my-addon3/__COMPILED_STYLES__/my-addon3.css", "./my-addon3/__COMPILED_STYLES__/nested/inner.css", "./my-addon3/__COMPILED_STYLES__/outer.css"]

       95 |
       96 |   test(`all addon CSS gets convert to implicit-styles`, function () {
    >  97 |     let implicitStyles = expectFile('node_modules/my-addon3/package.json').json().get('ember-addon.implicit-styles');
          |                          ^
       98 |     implicitStyles.includes('./my-addon3.css');
       99 |     implicitStyles.includes('./outer.css');
      100 |     implicitStyles.includes('./nested/inner.css');

      at Object.<anonymous> (packages/compat/tests/addon-styles.test.ts:97:26)


Test Suites: 2 failed, 40 passed, 42 total
Tests:       2 failed, 597 passed, 599 total
Snapshots:   0 total
Time:        490.237s

[stefanpenner]

some links potentially related to the above issue, leaving the notes here so I can easily resume later.

• Fix the path to the on-disk styles file for in-repo engines #709
• https://github.com/ember-cli/ember-cli/blob/b24b73b388934796ca915ca665b48a27c857199b/lib/broccoli/default-packager.js#L568
• https://github.com/ember-cli/ember-cli/blob/bd052719e76a9d15be7a7f2e20fa1b2c082a3700/lib/models/addon.js#L978-L980
• Ensure processed addon styles are not doubly-included in vendor.css ember-cli/ember-cli#9183

[stefanpenner]

Reading through the failures and the original changes suggests this is a safe change, and the tests merely need to be updated. Specifically it appears that the intermediate output has changed, but the consuming code is also correctly update to account for said change, resulting in the two errors we see now.

@rwjblue is on vacation, and he has most context. I'll sync with him when he returns, but I will likely update these tests and move on. I am pretty confident my analysis is sufficient.