Ensure dependencySatisfies invalidates when installed packages change
#913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
requested changes
Jul 30, 2021
There was a problem hiding this comment.
This seems good overall, though I did leave a couple notes about sharing / reuse.
I'd also love to see a test here, the reproduction in "real world" was pretty straight forward (running npm test which runs multiple ember-try scenarios back to back in an addon ought to have triggered this).
dependencySatisfies can become invalid if babel caches the macros plugin + the dependency that is being checked for changes its package version. This adds a cache busting plugin that tracks a hash of the contents of the apps lock file so any changes to dependencies will bust the cache. Fixes: embroider-build#906
thoov
force-pushed
the
marco-babel-cache-busting
branch
from
0b0d836
to
0ea82c1
Compare
Added a test to cover this and verified that removing the cache busting plugin it fails the test |
ef4
reviewed
Aug 5, 2021
thoov
force-pushed
the
marco-babel-cache-busting
branch
from
59c554d
to
f830fe4
Compare
rwjblue
reviewed
Aug 9, 2021
rwjblue
reviewed
Aug 9, 2021
rwjblue
approved these changes
Aug 9, 2021
rwjblue
changed the title
dependencySatisfies invalidates when installed packages change
thoov
added a commit
to thoov/ember-engines
that referenced
this pull request
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependencySatisfies can become invalid if babel caches the macros plugin + the dependency that is being checked for changes its package version. This adds a cache busting plugin that tracks a hash of the contents of the apps lock file so any changes to dependencies will bust the cache.
Fixes: #906