Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arguments to preprocessCss (to match classic build) #910

Merged
merged 4 commits into from
Jul 30, 2021

Conversation

thoov
Copy link
Collaborator

@thoov thoov commented Jul 28, 2021

In classic builds the second argument is '/app/styles' but we were passing 'app/styles'. While this difference might be small, in
ember-cli-eyeglass it removes the leading slash and this causes issues when the slash is missing. This PR aligns with what classic was doing along with adding a very simple test case.

Fixes: #908

@rwjblue rwjblue added the bug Something isn't working label Jul 28, 2021
@ef4
Copy link
Contributor

ef4 commented Jul 29, 2021

CI is now back to normal, the remaining failures here are real failures, I think.

In classic builds the second argument is '/app/styles' but we were
passing 'app/styles'. While this difference might be small, in
ember-cli-eyeglass [it removes the leading
slash](https://github.com/linkedin/eyeglass/blob/master/packages/ember-cli-eyeglass/src/index.ts#L210-L212)
and this causes issues when the slash is missing.
@thoov
Copy link
Collaborator Author

thoov commented Jul 30, 2021

@rwjblue This should be good to go

@rwjblue rwjblue changed the title Align second arg for preprocessCss to match classic Fix arguments to preprocessCss (to match classic build) Jul 30, 2021
@rwjblue rwjblue merged commit 034763b into embroider-build:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PreprocessCss receiving different inputs that break ember-cli-eyeglass
4 participants