Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deflate AdjustImportsOptions #907

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

krisselden
Copy link
Contributor

@krisselden krisselden commented Jul 27, 2021

The babel-loader cache key hashes babel options which has the AdjustImportsOptions used multiple times and is very large.

This PR moves this into a file ignoring caching for now since everything it moves is already memoized and only thing this affects is in-repo-addons and isDevelopingAddon true which is currently an issue.

This doesn't address relocatedFiles which is very large because it is outside the spot that is memoized.

The babel-loader cache key hashes babel options which has the
AdjustImportsOptions used multiple times and is very large.

This PR moves this into a file ignoring caching for now since everything
it moves is already memoized and only thing this affects is
in-repo-addons and isDevelopingAddon true which is currently an issue.

This doesn't address relocatedFiles which is very large because it is
outside the spot that is memoized.
@krisselden krisselden changed the title WIP deflate resolver config Deflate AdjustImportsOptions Jul 27, 2021
@rwjblue rwjblue added the enhancement New feature or request label Jul 28, 2021
@rwjblue rwjblue merged commit 8518888 into embroider-build:master Jul 28, 2021
@krisselden krisselden deleted the deflate-resolver-config branch July 28, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants