Only patch ember-cli-deprecation-workflow releases before 2.0.0
#900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure due to timeout seems to be present on |
|
@alexlafroscia you can also leverage |
|
Ah, even better! I had looked around at the other compat adapters for something like this but didn't come across one. I'll solve it that way instead! Edit: It doesn't seem like any compat adapters actually use this hook yet -- no wonder I didn't find it 😅 |
The `2.0.0` release of `ember-cli-deprecation-workflow` removes the package that required the compatibility adapter, so we can safely opt out of applying it if we're working with `2.0.0` or newer.
alexlafroscia
force-pushed
the
deprecation-workflow-patch
branch
from
f29d767
to
29811be
Compare
rwjblue
approved these changes
Jul 21, 2021
rwjblue
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an error when trying out Embroider in my main Ember app.
The compat adapter for
ember-cli-deprecation-workflowresolves an error withember-debug-handlers-polyfillwhich is no longer present in version2.0.0. Because it's not installed, Node is unable to resolve the location of the package.We should opt out of the patch if the installed version is
2.0.0or greater.