Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support inert TemplateLiteral in hbs plugin #899

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

eoneill
Copy link
Contributor

@eoneill eoneill commented Jul 20, 2021

This adds support for inert TemplateLiteral strings (with no sub-expressions) within the hbs call.

e.g.

hbs(`<foo>`)

Added test case; verified test fails (throws hbs accepts only a string literal argument) without the patch.

@rwjblue rwjblue added the bug Something isn't working label Jul 28, 2021
@rwjblue rwjblue merged commit 0a9f541 into embroider-build:master Jul 28, 2021
ef4 added a commit that referenced this pull request Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants