Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for apps that use babel 6 #890

Merged
merged 2 commits into from
Jul 5, 2021
Merged

Drop support for apps that use babel 6 #890

merged 2 commits into from
Jul 5, 2021

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Jul 5, 2021

  • We were using babel.template where babel.parse would be better. It's possible to serialize structures that look like a template to babel and then it would confusingly error.
  • Switching to better upstream types from babel, where we had an unnecessary custom type.
  • Dropping support for apps that use babel 6. Addons that use babel 6 will still work, because they compile themselves during stage1.

ef4 added 2 commits July 5, 2021 11:23
We were using babel.template where babel.parse would be better. It's possible to serialize structures that *look* like a template to babel and then it would confusingly error.

Also, switchiing to better upstream types from babel, where we had an unnecessary custom type.
@ef4 ef4 changed the title Avoid confusing failures in macros babel plugin Babel cleanup Jul 5, 2021
@ef4 ef4 added the breaking label Jul 5, 2021
@ef4 ef4 changed the title Babel cleanup Drop support for apps that use babel 6 Jul 5, 2021
@ef4 ef4 merged commit 3064442 into master Jul 5, 2021
@ef4 ef4 deleted the babel-cleanup branch July 5, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant