Drop support for apps that use babel 6 #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ef4
commented
Jul 5, 2021
•
ef4
commented
- We were using babel.template where babel.parse would be better. It's possible to serialize structures that look like a template to babel and then it would confusingly error.
- Switching to better upstream types from babel, where we had an unnecessary custom type.
- Dropping support for apps that use babel 6. Addons that use babel 6 will still work, because they compile themselves during stage1.
We were using babel.template where babel.parse would be better. It's possible to serialize structures that *look* like a template to babel and then it would confusingly error. Also, switchiing to better upstream types from babel, where we had an unnecessary custom type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.