undefined does not serialize with broccoli-babel-transpiler
#886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When broccoli-babel-transpiler tries to determine in a plugin is serializable it checks for certain types: https://github.com/babel/broccoli-babel-transpiler/blob/416732dd5d57b9f29dad7afd7f7cae76f0ac1606/lib/parallel-api.js#L45-L61. If the value is undefined it is not serializable and thus not parallelizable. Since we are just checking for truthyness of the appPackageRoot value we can instead use an empty string. This also satisfies the babel type which is string | undefined.
rwjblue
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When broccoli-babel-transpiler tries to determine if a plugin is serializable it checks for certain types.
If the value is undefined it is not serializable and thus not parallelizable. Since we are just checking for truthyness of the
appPackageRootvalue we can instead use an empty string. This also satisfies the babel type which is string | undefined.This comes up in production builds as
appPackageRootdoes not get set