Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite loop in local testing scenario building #869

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Fix infinite loop in local testing scenario building #869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/scenarios/scenarios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { dirname, delimiter } from 'path';
if (!voltaHome) return;
let paths = process.env['PATH']!.split(delimiter);
while (/\.volta/.test(paths[0])) {
paths.shift;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone was trying to write some ruby.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice the typo and copied it verbatim from volta-cli/volta#702.

We also found and fixed this in ember-auto-import, but not before it got copied to here. 🙃

paths.shift();
}
paths.unshift(`${voltaHome}/bin`);
process.env['PATH'] = paths.join(delimiter);
Expand Down