[WIP] [Fix #862] add emberSourceRealModules flag #866

stefanpenner · 2021-06-21T18:40:45Z

changes “real module” mode of ember-source to begin automatically at 4.0.0, rather then 3.27.0-beta.0
adds emberSourceRealModules option, to opt into this mode prior to 4.0.0
begins fixing [email protected] issues

TODO:

sync up with @thoov re: test-matrix stuff
debug the expected ember 3.27.x issues
possible solution for ^
ensure everything works
write tests based on discussion with @thoov

packages/core/src/options.ts

packages/compat/src/compat-app.ts

packages/compat/src/compat-adapters/ember-source.ts

packages/compat/src/compat-app.ts

stefanpenner · 2021-06-22T00:15:35Z

packages/core/src/app.ts

@@ -415,6 +416,17 @@ export class AppBuilder<TreeNames> {
      { absoluteRuntime: __dirname, useESModules: true, regenerator: false },
    ]);

+    {


needs cleanup

stefanpenner · 2021-06-22T00:15:43Z

packages/core/src/app.ts

@@ -1480,3 +1492,58 @@ function combinePackageJSON(...layers: object[]) {
  }
  return mergeWith({}, ...layers, custom);
 }
+
+function macroBabelPlugins() {


needs comment

stefanpenner · 2021-06-22T00:15:57Z

packages/core/src/options.ts

+  // This flag provideds adventurous ember-source users & addon-authors the
+  // ability to test & begin preperation prior to this feature becomeing the
+  // default.
+  emberSourceRealModules?: boolean | null;


we likely no longer need null here

stefanpenner · 2021-06-22T01:12:15Z

Test failures so far are just the expected deprecation warning. @rwjblue based on our chat, it would seem like we should allow those deprecations…. Although that does annoy me a little….

ef4 · 2021-06-22T14:02:37Z

I think if we use modules-api-polyfill it's going to cause deprecation spew on Ember 3.27+?

When code in a true ES module handled by webpack does:

import Component from '@ember/component'`

modules-api-polyfill will rewrite that to Ember.Component, which is deprecated.

We could instead configure webpack's externals so that it knows to defer these imports to runtime and access them via runtime require, which would make us compatible with what the classic build does in this case.

stefanpenner · 2021-06-22T16:54:01Z

We could instead configure webpack's externals so that it knows to defer these imports to runtime and access them via runtime require, which would make us compatible with what the classic build does in this case.

That approach sounds better. I'll give it whirl

stefanpenner · 2021-06-22T17:06:28Z

@ef4 It sounds like we may want to essentially add the data from https://github.com/ember-cli/ember-rfc176-data to webpack externals for users 2.27.0-alpha.0..4.0.0-alpha.0 unless the user opts into the emberSourceRealModules.... WDYT?

ef4 · 2021-06-22T17:26:37Z

@stefanpenner yes, but please try to use it via https://github.com/embroider-build/embroider/blob/7bab34a265e234ab45e8eaf40482f8dbce7aa5cc/packages/shared-internals/src/ember-standard-modules.ts which exists for this purpose.

ef4 · 2021-06-22T18:19:27Z

@stefanpenner I realized we probably already have enough support for externalizing ember dependencies in adjust-imports-plugin.

You may want to just try not doing anything to externalize the ember modules because this code probably already gets it right:

embroider/packages/core/src/babel-plugin-adjust-imports.ts

Lines 274 to 301 in 7bab34a

    
           // auto-upgraded packages can fall back to attmpeting to find dependencies at 
        
           // runtime. Native v2 packages can only get this behavior in the 
        
           // isExplicitlyExternal case above because they need to explicitly ask for 
        
           // externals. 
        
           if (pkg.meta['auto-upgraded']) { 
        
             return makeExternal(specifier, sourceFile, opts); 
        
           } 
        
           if (pkg.isV2Ember()) { 
        
             // native v2 packages don't automatically externalize *everything* the way 
        
             // auto-upgraded packages do, but they still externalize known and approved 
        
             // ember virtual packages (like @ember/component) 
        
             if (emberVirtualPackages.has(packageName)) { 
        
               return makeExternal(specifier, sourceFile, opts); 
        
             } 
        
             // native v2 packages don't automatically get to use every other addon as a 
        
             // peerDep, but they do get the known and approved ember virtual peer deps, 
        
             // like @glimmer/component 
        
             if (emberVirtualPeerDeps.has(packageName)) { 
        
               if (!opts.activeAddons[packageName]) { 
        
                 throw new Error( 
        
                   `${pkg.name} is trying to import from ${packageName}, which is supposed to be present in all ember apps but seems to be missing` 
        
                 ); 
        
               } 
        
               return explicitRelative(dirname(sourceFile.name), specifier.replace(packageName, opts.activeAddons[packageName])); 
        
             } 
        
           }

stefanpenner · 2021-06-22T18:45:58Z

You may want to just try not doing anything to externalize the ember modules because this code probably already gets it right:

If memory serves this fails (I dont have the exact failure handy), but I will begin investigation in about 1 -> 1.5h.

stefanpenner · 2021-07-21T19:42:40Z

I will resume this and now that #881 has landed, I bet some of the issues will be resolved.

stefanpenner · 2021-08-24T23:25:08Z

rebased (will continue to investigate as time permits)

stefanpenner · 2021-09-02T15:53:20Z

quick rebase again

stefanpenner · 2021-09-02T23:54:59Z

packages/compat/src/compat-adapters/ember-cli-fastboot.ts

@@ -141,6 +141,11 @@ class RewriteManifest extends Plugin {
      extraVendorFiles,
    };

+    json['ember-addon'] = {


i don't remember if this was actually important now, i think it isn't and should likely be removed

packages/router/tests/dummy/config/ember-cli-update.json

stefanpenner · 2021-09-07T17:42:11Z

packages/compat/src/addon-dependency-rules/ember-data.ts

@@ -4,6 +4,7 @@ let rules: PackageRules[] = [
  {
    package: '@ember-data/store',
    addonModules: {
+      //'-private/index.js': {


do i need this? I don't even remember.

packages/core/src/app.ts

packages/core/src/babel-plugin-adjust-imports.ts

stefanpenner · 2021-09-14T22:05:07Z

packages/core/src/app.ts

+    [
+      require.resolve('babel-plugin-ember-modules-api-polyfill'),
+      { ignore },
+      '@embroider/core:babel-plugin-ember-modules-api-polyfill',
+    ],
+    [
+      require.resolve('babel-plugin-debug-macros'),
+      {
+        flags: [
+          {
+            source: '@glimmer/env',
+            flags: { DEBUG: isDebug, CI: !!process.env.CI },
+          },
+        ],
+
+        externalizeHelpers: {
+          global: 'Ember',
+        },
+
+        debugTools: {
+          isDebug,
+          source: '@ember/debug',
+          assertPredicateIndex: 1,
+        },
+      },
+      '@embroider/core:@ember/debug stripping',
+    ],


Now that i re-enabled this block, I remember why I disabled it.

This block makes tests pass, but trips up against the globals warnings. Removing it makes some tests fail, especially when add-ons import things like @glimmer/tracking. There are several approaches we can take to address this, I hope to sync up with @ef4 tomorrow to discuss options.

* changes “real module” mode of ember-source to begin automatically at 4.0.0, rather then 3.27.0-beta.0 * adds emberSourceRealModules option, to opt into this mode prior to 4.0.0 * begins fixing [email protected] issues * replicate ember-cli-babel’s non-“Real module” mode when the emberSourceRealModules is false

ef4 · 2021-09-23T20:16:08Z

Closing in favor of #978

rwjblue · 2021-09-27T20:51:03Z

(I think @ef4 meant to close this with his comment above)

stefanpenner commented Jun 21, 2021

View reviewed changes

packages/core/src/options.ts Outdated Show resolved Hide resolved

stefanpenner force-pushed the 3-27-fixes branch 2 times, most recently from 6f992e3 to 8d11d3c Compare June 21, 2021 18:48

stefanpenner commented Jun 21, 2021

View reviewed changes

packages/core/src/options.ts Outdated Show resolved Hide resolved

thoov approved these changes Jun 21, 2021

View reviewed changes

stefanpenner added the bug Something isn't working label Jun 21, 2021

rwjblue reviewed Jun 21, 2021

View reviewed changes

packages/compat/src/compat-app.ts Outdated Show resolved Hide resolved

rwjblue reviewed Jun 21, 2021

View reviewed changes

packages/compat/src/compat-adapters/ember-source.ts Outdated Show resolved Hide resolved

packages/compat/src/compat-app.ts Outdated Show resolved Hide resolved

stefanpenner force-pushed the 3-27-fixes branch 2 times, most recently from d219a5a to 2d1e7d9 Compare June 21, 2021 23:20

stefanpenner mentioned this pull request Jun 21, 2021

Ember global not available to vendor code when using ember-source 3.27+ #862

Open

stefanpenner force-pushed the 3-27-fixes branch 3 times, most recently from 2959625 to 308b097 Compare June 22, 2021 00:14

stefanpenner commented Jun 22, 2021

View reviewed changes

stefanpenner force-pushed the 3-27-fixes branch from 308b097 to 356efcd Compare June 22, 2021 00:28

stefanpenner force-pushed the 3-27-fixes branch from 356efcd to c785d94 Compare August 24, 2021 23:24

stefanpenner mentioned this pull request Aug 30, 2021

bump ember-source to 3.27 #950

Closed

stefanpenner force-pushed the 3-27-fixes branch 3 times, most recently from bb807f1 to 995d02a Compare September 1, 2021 14:36

stefanpenner force-pushed the 3-27-fixes branch from 55b4a1e to 5a87c89 Compare September 2, 2021 15:52

stefanpenner force-pushed the 3-27-fixes branch 2 times, most recently from dc7e5d7 to b8ce0ed Compare September 2, 2021 22:45

stefanpenner commented Sep 2, 2021

View reviewed changes

stefanpenner force-pushed the 3-27-fixes branch 3 times, most recently from c9b7344 to 3aa84c8 Compare September 3, 2021 04:54

stefanpenner commented Sep 3, 2021

View reviewed changes

packages/router/tests/dummy/config/ember-cli-update.json Outdated Show resolved Hide resolved

stefanpenner force-pushed the 3-27-fixes branch 2 times, most recently from 8a3a299 to 2590547 Compare September 7, 2021 17:40

stefanpenner commented Sep 7, 2021

View reviewed changes

stefanpenner marked this pull request as draft September 8, 2021 19:22

stefanpenner force-pushed the 3-27-fixes branch from d6ccc3a to 867a385 Compare September 14, 2021 20:25

stefanpenner commented Sep 14, 2021

View reviewed changes

stefanpenner added 6 commits September 21, 2021 13:22

WIP

9121384

asdf

7080d5a

Update babel-plugin-adjust-imports.ts

148ce07

Update babel-plugin-adjust-imports.ts

511a444

Re-enable babel-plugin-ember-modules-api-polyfill

9ef5980

stefanpenner force-pushed the 3-27-fixes branch from 752c627 to 9ef5980 Compare September 21, 2021 19:22

rwjblue closed this Sep 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] [Fix #862] add emberSourceRealModules flag #866

[WIP] [Fix #862] add emberSourceRealModules flag #866

stefanpenner commented Jun 21, 2021 •

edited

Loading

stefanpenner Jun 22, 2021

stefanpenner Jun 22, 2021

stefanpenner Jun 22, 2021

stefanpenner commented Jun 22, 2021

ef4 commented Jun 22, 2021

stefanpenner commented Jun 22, 2021

stefanpenner commented Jun 22, 2021 •

edited

Loading

ef4 commented Jun 22, 2021

ef4 commented Jun 22, 2021

stefanpenner commented Jun 22, 2021 •

edited

Loading

stefanpenner commented Jul 21, 2021

stefanpenner commented Aug 24, 2021

stefanpenner commented Sep 2, 2021

stefanpenner Sep 2, 2021

stefanpenner Sep 7, 2021

stefanpenner Sep 14, 2021 •

edited

Loading

ef4 commented Sep 23, 2021

rwjblue commented Sep 27, 2021

[WIP] [Fix #862] add emberSourceRealModules flag #866

[WIP] [Fix #862] add emberSourceRealModules flag #866

Conversation

stefanpenner commented Jun 21, 2021 • edited Loading

stefanpenner Jun 22, 2021

Choose a reason for hiding this comment

stefanpenner Jun 22, 2021

Choose a reason for hiding this comment

stefanpenner Jun 22, 2021

Choose a reason for hiding this comment

stefanpenner commented Jun 22, 2021

ef4 commented Jun 22, 2021

stefanpenner commented Jun 22, 2021

stefanpenner commented Jun 22, 2021 • edited Loading

ef4 commented Jun 22, 2021

ef4 commented Jun 22, 2021

stefanpenner commented Jun 22, 2021 • edited Loading

stefanpenner commented Jul 21, 2021

stefanpenner commented Aug 24, 2021

stefanpenner commented Sep 2, 2021

stefanpenner Sep 2, 2021

Choose a reason for hiding this comment

stefanpenner Sep 7, 2021

Choose a reason for hiding this comment

stefanpenner Sep 14, 2021 • edited Loading

Choose a reason for hiding this comment

ef4 commented Sep 23, 2021

rwjblue commented Sep 27, 2021

stefanpenner commented Jun 21, 2021 •

edited

Loading

stefanpenner commented Jun 22, 2021 •

edited

Loading

stefanpenner commented Jun 22, 2021 •

edited

Loading

stefanpenner Sep 14, 2021 •

edited

Loading