Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when an asset cannot be found in entry file #853

Merged

Conversation

thoov
Copy link
Collaborator

@thoov thoov commented Jun 15, 2021

This is an error we have hit in all of our internal apps migrated thus far and wanted to improve the messaging for future travelers.

New error message:

Screen Shot 2021-06-15 at 12 45 57 PM

Old error message:

Screen Shot 2021-06-15 at 12 47 33 PM

Additionally, created the following wiki entry that gives more context for it: https://github.com/thoov/stitch/wiki/Could-not-find-asset-in-entry-file-error-help

Copy link
Collaborator

@stefanpenner stefanpenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@rwjblue rwjblue added the bug Something isn't working label Jun 16, 2021
@rwjblue rwjblue merged commit ea804e5 into embroider-build:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants