[hygiene] Volta pin latest node / yarn

[stefanpenner]

No description provided.

[stefanpenner]

@ef4 any concerns with this? Or do we keep the version of node / yarn more conservative for a reason?

[rwjblue]

We'll also have to fix up our exports or the imports that use things that aren't included in exports, on Node 16 the exports property is enforced. CI is failing for this reason:

Package subpath './src/load-ember-template-compiler' is not defined by "exports" in /home/runner/work/embroider/embroider/node_modules/@embroider/core/package.json

[rwjblue]

#851 should address that last item

[rwjblue]

Or do we keep the version of node / yarn more conservative for a reason?

@stefanpenner - We generally want to test on the "lowest supported platform" (to make sure we still support whatever is our oldest node), but as you can tell we have issues with newer Nodes too. Maybe we should have at least one set of tests that run with oldest and newest?

[ef4]

The test upgrade work that @thoov has started can address this. In ember-auto-import where we have the same concerns, we can switch node versions per scenario. https://github.com/ef4/ember-auto-import/blob/27485d4dc76de152b7bfb1efb49e5a06fc565197/test-scenarios/scenarios.ts#L24

[stefanpenner]

@ef4 I'll coordinate with @thoov

[stefanpenner]

Online conversations, everyone seemed ok with this choice as a baseline. We can always add additional test scenarios + node permutations.