Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hygiene] Volta pin latest node / yarn #843

Merged
merged 1 commit into from
Aug 25, 2021
Merged

[hygiene] Volta pin latest node / yarn #843

merged 1 commit into from
Aug 25, 2021

Conversation

stefanpenner
Copy link
Collaborator

No description provided.

@stefanpenner
Copy link
Collaborator Author

@ef4 any concerns with this? Or do we keep the version of node / yarn more conservative for a reason?

package.json Outdated Show resolved Hide resolved
@rwjblue
Copy link
Collaborator

rwjblue commented Jun 11, 2021

We'll also have to fix up our exports or the imports that use things that aren't included in exports, on Node 16 the exports property is enforced. CI is failing for this reason:

Package subpath './src/load-ember-template-compiler' is not defined by "exports" in /home/runner/work/embroider/embroider/node_modules/@embroider/core/package.json

@rwjblue
Copy link
Collaborator

rwjblue commented Jun 15, 2021

#851 should address that last item

@rwjblue
Copy link
Collaborator

rwjblue commented Jun 15, 2021

Or do we keep the version of node / yarn more conservative for a reason?

@stefanpenner - We generally want to test on the "lowest supported platform" (to make sure we still support whatever is our oldest node), but as you can tell we have issues with newer Nodes too. Maybe we should have at least one set of tests that run with oldest and newest?

@ef4
Copy link
Contributor

ef4 commented Jun 15, 2021

The test upgrade work that @thoov has started can address this. In ember-auto-import where we have the same concerns, we can switch node versions per scenario. https://github.com/ef4/ember-auto-import/blob/27485d4dc76de152b7bfb1efb49e5a06fc565197/test-scenarios/scenarios.ts#L24

@stefanpenner
Copy link
Collaborator Author

@ef4 I'll coordinate with @thoov

@stefanpenner
Copy link
Collaborator Author

Online conversations, everyone seemed ok with this choice as a baseline. We can always add additional test scenarios + node permutations.

@stefanpenner stefanpenner merged commit b75a9b2 into master Aug 25, 2021
@stefanpenner stefanpenner deleted the volta branch August 25, 2021 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants