Remove ember-cli-htmlbars-inline-precompile in test packages
#837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove ember-cli-htmlbars-inline-precompile which is not needed with ember-cli-htmlbars >= 4.x. When both are together, some ember try scenarios fail. Since this is no longer needed, removing it entirely is the best solution for moving forward.
|
Once CI completes if green, I will attempt to remove all occurrences of inline-precompile. As we are using |
|
bummer, problem still occurs. Even though my isolated reproduction appeared to be ok... mystery continues.. |
stefanpenner
changed the title
rwjblue
approved these changes
Jun 7, 2021
rwjblue
changed the title
ember-cli-htmlbars-inline-precompile in test packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove ember-cli-htmlbars-inline-precompile as it is no longer needed