Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ember-cli-htmlbars-inline-precompile in test packages #837

Merged
merged 2 commits into from
Jun 7, 2021

Conversation

stefanpenner
Copy link
Collaborator

@stefanpenner stefanpenner commented Jun 4, 2021

remove ember-cli-htmlbars-inline-precompile as it is no longer needed

remove ember-cli-htmlbars-inline-precompile which is not needed with
ember-cli-htmlbars >= 4.x. When both are together, some ember try scenarios fail. 

Since this is no longer needed, removing it entirely is the best solution for moving forward.
@stefanpenner
Copy link
Collaborator Author

stefanpenner commented Jun 4, 2021

Once CI completes if green, I will attempt to remove all occurrences of inline-precompile. As we are using ember-cli-htmlbars >= 4.x

@stefanpenner
Copy link
Collaborator Author

bummer, problem still occurs. Even though my isolated reproduction appeared to be ok... mystery continues..

@stefanpenner stefanpenner changed the title [Fix] fix “TypeError: block is not iterable” when running tests locally remove ember-cli-htmlbars-inline-precompile as it is no longer needed Jun 4, 2021
@rwjblue rwjblue merged commit 87548d4 into master Jun 7, 2021
@rwjblue rwjblue deleted the fix-block-is-not-iterable branch June 7, 2021 17:54
@rwjblue rwjblue changed the title remove ember-cli-htmlbars-inline-precompile as it is no longer needed Remove ember-cli-htmlbars-inline-precompile in test packages Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants