Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configPath to locate the configuration file, instead of assuming a fixed path #797

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

charlespierce
Copy link
Contributor

Info

The compatAdapter for ember-get-config currently assumes that the configuration file is always in config/environment.js. However, it is possible to change the config directory with a setting in package.json. If that is done, the compat adapter will fail when it tries to require a file that doesn't exist.

Changes

  • Updated V1App to provide access to Ember's method of locating the environment file.
  • Updated the ember-get-config adapter to use the above, instead of assuming that it's always at config/environment.js

@ef4 ef4 merged commit 76d9546 into embroider-build:master Apr 30, 2021
@ef4
Copy link
Contributor

ef4 commented Apr 30, 2021

Thanks.

@rwjblue rwjblue added the bug Something isn't working label May 4, 2021
@charlespierce charlespierce deleted the handle_config_path branch May 26, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants