Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install webpack alongside @embroider/webpack when using @embroider/test-setup #792

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

alexlafroscia
Copy link
Contributor

Since webpack is a peer dependency to @embroider/webpack now, the @embroider/test-setup package should also install that as part of the "Ember Try" configuration that it generates.

bendemboski added a commit to bendemboski/ember-add-listener-helper that referenced this pull request Apr 29, 2021
@ef4 ef4 merged commit c592103 into embroider-build:master Apr 29, 2021
@ef4
Copy link
Contributor

ef4 commented Apr 29, 2021

Thanks, good call.

bendemboski added a commit to bendemboski/ember-add-listener-helper that referenced this pull request Apr 29, 2021
@rwjblue rwjblue added the bug Something isn't working label May 4, 2021
@rwjblue rwjblue changed the title fix(test-setup): install webpack alongside @embroider/webpack Install webpack alongside @embroider/webpack when using @embroider/test-setup May 4, 2021
bendemboski added a commit to bendemboski/ember-add-listener-helper that referenced this pull request May 5, 2021
bendemboski added a commit to bendemboski/ember-add-listener-helper that referenced this pull request May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants