Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve semver checks for the modules polyfill #785

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Improve semver checks for the modules polyfill #785

merged 2 commits into from
Apr 29, 2021

Conversation

sandydoo
Copy link
Contributor

@sandydoo sandydoo commented Apr 27, 2021 •
edited
Loading

This improves the semver checks to enable the following features for the beta versions of the 3.27 release:

  • Use real Ember modules
  • Disable module polyfills. These also happen to use the Ember global, which throws deprecation notices in 3.27+.

Fixes #781.
Fixes #787.
Fixes #794.

I think that’s all of ’em!

@sandydoo sandydoo mentioned this pull request Apr 27, 2021
Closed
3 tasks
@sandydoo
Improve semver check for modules polyfill
fe373f7 
The polyfill uses the Ember global, which is deprecated in `3.27.0`.
This additionally disables the polyfill for the `3.27.0-beta.x` ranges.

Fixes embroider-build#781.
@sandydoo sandydoo force-pushed the fix-semver-check-for-modules-polyfill branch from ba7f60d to fe373f7 Compare April 27, 2021 03:02
@sandydoo sandydoo mentioned this pull request Apr 27, 2021
Closed
rwjblue
rwjblue approved these changes Apr 27, 2021
View reviewed changes
Copy link
Collaborator

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

rwjblue
rwjblue reviewed Apr 27, 2021
View reviewed changes
Copy link
Collaborator

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, the CI stalling that we are seeing here is for ember-beta and canary only. I wonder if it is actually related to the changes...

@sandydoo - Do you have any time to dig into the test locally?

@sandydoo sandydoo changed the title Improve semver check for the modules polyfill Improve semver checks for the modules polyfill Apr 27, 2021
@sandydoo
Copy link
Contributor Author

@sandydoo - Do you have any time to dig into the test locally?

I’ll take a look, @rwjblue. I just found another place where this check is done, which fixes #787. I think with that the virtual/module polyfill stuff is finally disabled.

@sandydoo
Copy link
Contributor Author

Woot! We’re in the green 😄

@sandydoo sandydoo mentioned this pull request Apr 29, 2021
Closed
@ef4 ef4 merged commit 12ac1d8 into embroider-build:master Apr 29, 2021
@rwjblue rwjblue added the bug Something isn't working label May 4, 2021
@RobbieTheWagner
Copy link

Has this been released yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@sandydoo @RobbieTheWagner @rwjblue @ef4