Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to addon shim #773

Merged
merged 4 commits into from
Apr 24, 2021
Merged

Updates to addon shim #773

merged 4 commits into from
Apr 24, 2021

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Apr 23, 2021

This moves v1AddonShim to its own package (@embroider/addon-shim), because of how we decided to ship ember-auto-import 2.0. People who want the other things in @embroider/util shouldn't be forced to adopt ember-auto-import 2.0, since that implies that all consumers of your package will also need to adopt it.

ef4 added 4 commits April 22, 2021 10:52
So that it can depend on ember-auto-import 2.0 without making users of the other shim utilities depend on it.
@ef4 ef4 merged commit 6e427f6 into master Apr 24, 2021
@ef4 ef4 deleted the addon-shim branch April 24, 2021 03:13
@ef4 ef4 added the enhancement New feature or request label Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant