Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting more build environments #748

Merged
merged 28 commits into from
Mar 28, 2021
Merged

Supporting more build environments #748

merged 28 commits into from
Mar 28, 2021

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Mar 28, 2021

  • adds an alternative eager implementation for importSync that works in all ES module environments (at the cost of making some synchronous-but-lazy things become eager)
  • refactored core so that parts of it are easier to consume from browser code without pulling in node-specific features
  • updated app-js and fastboot-js metadata to a stricter form that requires all files by listed explicitly, not just the directories.
  • made it easier for compat adapters to edit the output package.json, beyond just the ember-addon section.
  • updated several places to keep explicit file extensions within the build, where in the past we were unnecessarily stripping them off

This has the benefit of not requiring anything beyond web standards, and the downside of making some things eager that used to be lazy.
and it breaks right now anyway due to ownedByEmberPackage
and use it in ember-source compat adapter to make sure we keep the template compiler
Because it's extended to account for non-resolvable deps.
@ef4 ef4 marked this pull request as ready for review March 28, 2021 13:49
@ef4 ef4 merged commit 031ce6d into master Mar 28, 2021
@ef4 ef4 deleted the the-platform branch March 28, 2021 13:50
@ef4 ef4 added the enhancement New feature or request label Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant