Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better support for skipping Stage 1 transforms that are not needed #747

Merged
merged 2 commits into from
Mar 28, 2021

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Mar 27, 2021

This adds filtering for a newer stock plugin added by ember-cli-htmlbars, and ensures that filtered babel plugins don't trigger custom transpilation at stage1.

ef4 added 2 commits March 27, 2021 18:31
This adds filtering for a newer stock plugin added by ember-cli-htmlbars. Next we need to also do this filtering before counting the present plugins in `needsCustomBabel` to skip it entirely.
Because some addons call ember-cli-babel directly (boo!), which thankfully we already have test coverage for (yay!).
@ef4 ef4 merged commit a22223d into master Mar 28, 2021
@ef4 ef4 deleted the better-custom-babel-skipping branch March 28, 2021 01:49
@rwjblue rwjblue added the bug Something isn't working label Mar 29, 2021
@rwjblue rwjblue changed the title better skipping of unnecessary stage1 transforms Add better support for skipping Stage 1 transforms that are not needed Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants