Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "real modules" for ember-source when possible (3.27+) #740

Merged
merged 19 commits into from
Mar 27, 2021

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Mar 25, 2021

This does our first fully-static build of everything in ember-source!

This won't pass CI yet, I only fixed the canary case and now need to go back and add switches so we do things the older way on earlier ember versions.

Fixes #738.

ef4 added 2 commits March 26, 2021 05:30
This seems fully-working with staticAddonTrees off, and with them on the apps boots but we have an issue with the test setup.
@ef4 ef4 changed the title Ember deprecations Ember beta/canary updates Mar 26, 2021
@ef4
Copy link
Contributor Author

ef4 commented Mar 27, 2021

I did a lot of yak shaving here but now we're in a good place.

@ef4 ef4 merged commit fb86676 into master Mar 27, 2021
@ef4 ef4 deleted the ember-deprecations branch March 27, 2021 19:31
@rwjblue rwjblue added the enhancement New feature or request label Mar 29, 2021
@rwjblue rwjblue changed the title Ember beta/canary updates Use "real modules" for ember-source when possible (3.27+) Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected deprecations when running against Ember 3.27+
2 participants