Handle case where node_modules are symlinked #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Mar 1, 2021
thoov
added a commit
to thoov/ember-cli
that referenced
this pull request
Mar 8, 2021
This includes a fix for when a project's node_modules are symlinked which is the case for how ember-cli's test suite works: embroider-build/embroider#702
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving packages the code handled the case where individual node modules were symlinked but did not handle the cases when all of node_modules (or sub directories) were symlinks themselves. This happens when ember-cli's test suite creates a cache of node_modules that it symlinks into individual test case tmp directories and tries to invoke builds from there.