Refactor suite-setup-util to avoid knock on errors. #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
make-suite-setup-util-more-resilient
branch
from
d0a51ce
to
33012e2
Compare
ef4
approved these changes
Feb 24, 2021
This is a small refactor that does a few things: * migrate the manual promise chaining to async/await * unify the error handling (so that it is all done in the same way) * migrate from `process.stderr.write` to `console.error` (`process.stderr.write` only accepts a string or buffer, if you pass it an instance of `Error` you get an error that actually masks the _real_ error) * migrate to `process.exitCode` instead of `process.exit` (forcing exit with `process.exit()` _in general_ should be avoided, and doesn't seem required in this context)
rwjblue
force-pushed
the
make-suite-setup-util-more-resilient
branch
from
33012e2
to
50153f4
Compare
|
Rebased to get the canary build fixes... |
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactor that does a few things:
process.stderr.writetoconsole.error(process.stderr.writeonly accepts a string or buffer, if you pass it an instance ofErroryou get an error that actually masks the real error)process.exitCodeinstead ofprocess.exit(forcing exit withprocess.exit()in general should be avoided, and doesn't seem required in this context)