Strip main field from v1 addons' package.json once they are rewritten as V2
#687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1 addons don't get to customize `main` in package.json. When rewriting them to v2, we always rewrite them to put their main at `index.js` anyway. The presence of these fields can confuse stage3 packagers.
I don't understand this. V1 addons definitely can customize |
|
Ah, I see. This is talking about the interim state while upgrading them to v2, sorry for the noise. |
|
Correct, this is about how they look after being auto-upgraded to v2. We do take into account any customized main as they’re being rewritten, but the output is never customized. |
|
Ya, sorry about that. |
rwjblue
changed the title
main field from v1 addons' package.json once they are rewritten as V2
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1 addons don't get to customize
mainin package.json. When rewriting them to v2, we always rewrite them to put their main atindex.jsanyway. The presence of these fields can confuse stage3 packagers.