Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip main field from v1 addons' package.json once they are rewritten as V2 #687

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Feb 9, 2021

v1 addons don't get to customize main in package.json. When rewriting them to v2, we always rewrite them to put their main at index.js anyway. The presence of these fields can confuse stage3 packagers.

v1 addons don't get to customize `main` in package.json. When rewriting them to v2, we always rewrite them to put their main at `index.js` anyway. The presence of these fields can confuse stage3 packagers.
@ef4 ef4 merged commit 1410ea2 into master Feb 9, 2021
@rwjblue
Copy link
Collaborator

rwjblue commented Feb 9, 2021

v1 addons don't get to customize main in package.json

I don't understand this. V1 addons definitely can customize main (I have used htis a number of times to make typescript smart enough to know that addon/index.ts is the right entry point for example).

@rwjblue
Copy link
Collaborator

rwjblue commented Feb 9, 2021

Ah, I see. This is talking about the interim state while upgrading them to v2, sorry for the noise.

@ef4
Copy link
Contributor Author

ef4 commented Feb 10, 2021

Correct, this is about how they look after being auto-upgraded to v2. We do take into account any customized main as they’re being rewritten, but the output is never customized.

@rwjblue
Copy link
Collaborator

rwjblue commented Feb 11, 2021

Ya, sorry about that.

@rwjblue rwjblue added the bug Something isn't working label Mar 1, 2021
@rwjblue rwjblue changed the title clear main fields from v1 addons when rewriting them Strip main field from v1 addons' package.json once they are rewritten as V2 Mar 1, 2021
@rwjblue rwjblue deleted the clear-main branch March 1, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants